Add image support in TUI#13908
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds TUI image attachment support, including a new attachment bar, paste/path ingestion, clipboard image handling, input-mode locking, keybindings, and render/model tests.
Concerns
- The PR changes user-visible TUI behavior, but the description does not include the required terminal transcript, render snapshot diff, or
./script/run-tuicapture demonstrating the end-to-end flow. For this user-facing TUI change, please include one of those artifacts before merge. - Pasted image paths are read fully into memory before any explicit byte cap is applied, which can stall or crash the TUI for very large files.
Security
- The pasted-path ingestion path accepts user-controlled file paths and can perform unbounded memory allocation before rejecting oversized images.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
490d3b8 to
a6a4b07
Compare
harryalbert
left a comment
harryalbert
left a comment
There was a problem hiding this comment.
Nice, just had one small nit
| } | ||
| } | ||
|
|
||
| fn parse_image_paths(text: &str, cwd: &Path) -> Option<Vec<PathBuf>> { |
There was a problem hiding this comment.
It might be nice just from an organization perspective to have a separate file for image processing vs attachment bar state bookkeeping
2 participants
Description
Adds image attachments to Warp's TUI Agent prompts.
Linked Issue
N/A
Testing
./script/run-tuicargo nextest run -p warp_tui --no-fail-fast— 342 passed.cargo nextest run -p warpui_core --features tui --no-fail-fast— 500 passed, 7 skipped.cargo clippy -p warp_tui -p warpui -p warpui_core --all-targets -- -D warnings./script/formatAgent Mode
CHANGELOG-IMPROVEMENT: Added support for attaching images to prompts in Warp's TUI.